Drop Container Component Statuses #121
Conversation
|
@zakiva IIRC there's a BZ to link, right? |
Just added it :) |
zakiva
force-pushed
the
drop_component_statuses
branch
2 times, most recently
from
87ec298 to
e697d8c
Compare
|
Checked commit zakiva@e697d8c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
| {:name => 'persistent_volumes'}, {:name => 'persistent_volume_claims'}, | ||
| # workaround for: https://github.com/openshift/origin/issues/5865 | ||
| {:name => 'component_statuses', :default => []} | ||
| {:name => 'persistent_volumes'}, {:name => 'persistent_volume_claims'} |
There was a problem hiding this comment.
nit: do you mind keeping the trailing comma? (not everyone likes them, your call)
There was a problem hiding this comment.
I don't like it :)
(and it wasn't there in the first place)
|
AFAIU this patch should be safe to merge |
@moolitayer feel free to merge (sync with @zakiva ) when ready if decoupled from the other PRs. |
|
@moolitayer yeah this should be safe to merge now, actually, it has to be merged before we remove the class/table in the main and schema repos. |
|
✂️ 🔥 ✂️ 🔥 ✂️ |
Followup to ManageIQ/manageiq-providers-kubernetes#121 Removed (by manual editing) https://host.example.com:8443/api/v1/componentstatuses requests from cassette to avoid "unused interactions" error. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1485431
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1485431
Schema: ManageIQ/manageiq-schema#79
Core: ManageIQ/manageiq#16055
UI: ManageIQ/manageiq-ui-classic#2246